Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct some spellings & links in documents. #5205

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Correct some spellings & links in documents. #5205

merged 1 commit into from
Jan 19, 2022

Conversation

fanruinet
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 7, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jan 7, 2022

Thanks for your contribution!

@fanruinet fanruinet mentioned this pull request Jan 7, 2022
Closed
@Evezerest Evezerest self-assigned this Jan 10, 2022
@Evezerest Evezerest added the community Improvement from the community label Jan 10, 2022
Evezerest
Evezerest reviewed Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@Evezerest Evezerest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

十分感谢你的帮助，为PaddleOCR的文档找出了诸多错误。其中有部分修改可能需要重新提交，如果有疑问或需要沟通，请加入微信群后@本账号。期待与你联系！

README_ch.md Outdated
@@ -80,7 +80,8 @@ PaddleOCR旨在打造一套丰富、领先、且实用的OCR工具库，助力

- [运行环境准备](./doc/doc_ch/environment.md)
- [快速开始（中英文/多语言/文档分析）](./doc/doc_ch/quickstart.md)
- [PaddleOCR全景图与项目克隆](./doc/doc_ch/paddleOCR_overview.md)
- [PaddleOCR全景图](./doc/doc_ch/paddleOCR_overview.md)
- [快速安装](./doc/doc_ch/installation.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好，installation.md已经废弃，保留原始写法即可

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按审查意见更新。

deploy/cpp_infer/readme_en.md
This section will introduce how to configure the C++ environment and complete it in the Linux\Windows (CPU\GPU) environment
PaddleOCR model deployment.
This chapter introduces the C++ deployment steps of the PaddleOCR model. The corresponding Python predictive deployment method refers to [document](../../doc/doc_ch/inference.md).
C++ is better than python in terms of performance. Therefore, in CPU and GPU deployment scenarios, C++ deployment is mostly used.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处请 @LDOUBLEV review

doc/doc_ch/paddleOCR_overview.md Outdated
@@ -1,4 +1,4 @@
# PaddleOCR全景图与项目克隆
# PaddleOCR全景图
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此文件可以不进行更改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按审查意见还原此处修改。

doc/doc_en/distributed_training.md Outdated
@@ -2,7 +2,7 @@

## Introduction

The high performance of distributed training is one of the core advantages of PaddlePaddle. In the classification task, distributed training can achieve almost linear speedup ratio. Generally, OCR training task need massive training data. Such as recognition, ppocrv2.0 model is trained based on 1800W dataset, which is very time-consuming if using single machine. Therefore, the distributed training is used in paddleocr to speedup the training task. For more information about distributed training, please refer to [distributed training quick start tutorial](https://fleet-x.readthedocs.io/en/latest/paddle_fleet_rst/parameter_server/ps_quick_start.html).
The high performance of distributed training is one of the core advantages of PaddlePaddle. In the classification task, distributed training can achieve almost linear speedup ratio. Generally, OCR training task need massive training data. Such as recognition, PPOCR v2.0 model is trained based on 1800W dataset, which is very time-consuming if using single machine. Therefore, the distributed training is used in PaddleOCR to speedup the training task. For more information about distributed training, please refer to [distributed training quick start tutorial](https://fleet-x.readthedocs.io/en/latest/paddle_fleet_rst/parameter_server/ps_quick_start.html).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处的标准写法应该是PP-OCR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按审查意见更新。

doc/doc_en/paddleOCR_overview_en.md Outdated
@@ -1,4 +1,4 @@
# PaddleOCR Overview and Project Clone
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此文件可以不进行修改

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此文件已经还原，但它的翻译仍然有需要改进的地方，因此我还原后又进行了部分改进。

README.md Outdated
@@ -102,7 +102,8 @@ For a new language request, please refer to [Guideline for new language_requests
## Tutorials
- [Environment Preparation](./doc/doc_en/environment_en.md)
- [Quick Start](./doc/doc_en/quickstart_en.md)
- [PaddleOCR Overview and Project Clone](./doc/doc_en/paddleOCR_overview_en.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处可以保留原始写法

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按审查意见还原此处更改。

README.md Outdated
- Ultra lightweight PP-OCRv2 series models: detection (3.1M) + direction classifier (1.4M) + recognition 8.5M) = 13.0M
- Ultra lightweight PP-OCR mobile series models: detection (3.0M) + direction classifier (1.4M) + recognition (5.0M) = 9.4M
- General PP-OCR server series models: detection (47.1M) + direction classifier (1.4M) + recognition (94.9M) = 143.4M
- Support Chinese, English, and digit recognition, vertical text recognition, and long text recognition
- Support multi-language recognition: about 80 languages like Korean, Japanese, German, French, etc
- Supports Chinese, English, and digit recognition, vertical text recognition, and long text recognition
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这五条都作为单独特性，可以作为单独一句话，下方相同，可以保留support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已按审查意见更改。

@fanruinet
Copy link
Contributor Author

I've updated and force-pushed the branch according to the review comments above.

@fanruinet fanruinet requested a review from Evezerest January 10, 2022 11:59
@fanruinet
Copy link
Contributor Author

A new change was added in paddleocr.py.

Evezerest
Evezerest approved these changes Jan 19, 2022
View reviewed changes
Copy link
Collaborator

@Evezerest Evezerest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 特别鸣谢

@Evezerest Evezerest merged commit 8ee42d2 into PaddlePaddle:dygraph Jan 19, 2022
@Evezerest
Copy link
Collaborator

同时，上述修改请cherry-pick到 release2.4分支上，您就可以在Contributor中看到自己了，再次感谢

This was referenced Jan 21, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evezerest Evezerest Evezerest approved these changes

Assignees

@Evezerest Evezerest

Labels
community Improvement from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanruinet @CLAassistant @Evezerest